Vice President JD Vance seized the spotlight at the Republican midterm convention in Dallas, delivering a keynote that left the arena chanting